Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run clang-tidy #765

Merged
merged 1 commit into from
Dec 15, 2021
Merged

run clang-tidy #765

merged 1 commit into from
Dec 15, 2021

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 14, 2021

Define clang-tidy and clang-format configs based on google-* checks and Google style.

@sergiud sergiud added this to the 0.6 milestone Dec 14, 2021
@sergiud sergiud requested a review from drigz December 14, 2021 20:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021 •
edited
Loading

Codecov Report

Merging #765 (666622c) into master (d09b999) will decrease coverage by 0.18%.
The diff coverage is 40.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
- Coverage   73.01%   72.83%   -0.19%     
==========================================
  Files          17       17              
  Lines        3217     3228      +11     
==========================================
+ Hits         2349     2351       +2     
- Misses        868      877       +9
Impacted Files Coverage Δ
src/signalhandler.cc 6.45% <0.00%> (-0.09%) ⬇️
src/vlog_is_on.cc 70.22% <0.00%> (-1.09%) ⬇️
src/logging.cc 73.60% <33.33%> (-0.27%) ⬇️
src/symbolize.cc 64.11% <33.33%> (ø)
src/demangle.cc 97.48% <100.00%> (+<0.01%) ⬆️
src/stacktrace_libunwind-inl.h 90.00% <100.00%> (ø)
src/stacktrace_x86_64-inl.h 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09b999...666622c. Read the comment docs.

@sergiud sergiud merged commit 9dc1107 into master Dec 15, 2021
@sergiud sergiud deleted the clang-tidy branch December 15, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drigz drigz drigz approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiud @codecov-commenter @drigz